-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add start script and state sync script #219
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution Jacob! I believe this script will be helpful for starting a node. Could you move this script to somewhere like scripts/statesync.sh
(so that it does not mess with the root directory) and add a Makefile entry for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's very useful! I suggest making the RPC endpoint a parameter so we can enable syncing with both a testnet and a mainnet (but it can default to a particular value to enable easy functionality)
Co-authored-by: Vitalis Salis <[email protected]>
Co-authored-by: Vitalis Salis <[email protected]>
Co-authored-by: Vitalis Salis <[email protected]>
This reverts commit 9d7e2cd.
I think that we should wait for Makefile integration, till we have a steady network going that can reliably be synced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thing that we can improve upon is the hardcoded URL for the mainnet, but since this will be a hardcoded one eitherway when we release a stable version, I expect this won't be an issue (when we merge this, I agree that we should wait).
Btw, this PR seems to have some extra commits (about releases). Don't seem to affect anything, just fyi.
This adds a script that makes working with babylon more ergonomic by
making node setups easier